New Forgery Method -- Needs Addressing in Future Releases (fwd)

Date: Sun, 23 Mar 1997 11:49:51 -0400
From: "David L. Potter" <ab934@chebucto.ns.ca>
To: csuite-tech@chebucto.ns.ca
cc: Trent MacDougall <trent@chebucto.ns.ca>
Precedence: bulk

next message in archive
no next message in thread
previous message in archive
Index of Subjects



---------- Forwarded message ----------
Date: Sat, 22 Mar 1997 15:45:27 -0400
From: Jason L Tibbitts III <tibbs@hpc.uh.edu>
To: majordomo-workers@greatcircle.com
Cc: rogerk@QueerNet.ORG
Subject: Re: New Forgery Method -- Needs Addressing in Future Releases

>>>>> "JLT" == Jason L Tibbitts <tibbs@hpc.uh.edu> writes:

JLT> You are correct about that; the approval address should be in the
JLT> config file.  We have 'moderator' but that only handles BOUNCEs.  A
JLT> patch should be pretty simple.

I decided it wouldn't take that long, so here's a stab at it.  I have not
tested this, but it compiles without problems.  This adds an
approval_address config option.  I did not change any reference to
listname-approval in any message sent to users, since that would defeat the
purpose.  You'll still need a listname-approval address for user questions
in addition to wherever you choose to sent these messages.

--- majordomo.orig	Mon Jan 20 15:23:09 1997
+++ majordomo	Sat Mar 22 13:35:35 1997
@@ -463,7 +463,11 @@
 		  print REPLY "Succeeded.\n";
 		}
 		&log("unsubscribe $clean_list $subscriber");
-		&sendmail(BYE, "$clean_list-approval\@$whereami",
+		$approval_address =
+		  $config_opts{$clean_list,"approval_address"} ||
+		  "$clean_list-approval";
+		$approval_address .= "\@$whereami" unless $approval_address =~ /\@/;
+		&sendmail(BYE, "$approval_address",
 			  "UNSUBSCRIBE $clean_list");
 		print BYE "$subscriber has unsubscribed from $clean_list.\n";
 		print BYE "No action is required on your part.\n";
@@ -1569,10 +1573,15 @@
     local($cmd) = shift;
     local($list) = &valid_list($listdir, shift);
     local($subscriber) = @_;
+    local($approval_address);
     local(*APPROVE);
 
+    $approval_address =
+      $config_opts{$clean_list,"approval_address"} ||
+      "$clean_list-approval";
+    $approval_address .= "\@$whereami" unless $approval_address =~ /\@/;
     # open a sendmail process for the approval request
-    &sendmail(APPROVE, "$list-approval\@$whereami", "APPROVE $list");
+    &sendmail(APPROVE, "$approval_address", "APPROVE $list");
 
     # Generate the approval request
     print APPROVE <<"EOM";
@@ -1720,8 +1729,13 @@
     # close (and thereby send) the welcome message to the subscriber
     close(MSG);
 
+    $approval_address =
+      $config_opts{$clean_list,"approval_address"} ||
+      "$clean_list-approval";
+    $approval_address .= "\@$whereami" unless $approval_address =~ /\@/;
+
     # tell the list owner of the new subscriber
-    &sendmail(NOTICE, "$list-approval\@$whereami", "SUBSCRIBE $list");
+    &sendmail(NOTICE, "$approval_address\@$whereami", "SUBSCRIBE $list");
     print NOTICE "$subscriber has been added to $list.\n";
     print NOTICE "No action is required on your part.\n";
     close(NOTICE);
--- config_parse.pl.orig	Mon Dec 23 09:03:24 1996
+++ config_parse.pl	Sat Mar 22 13:39:15 1997
@@ -102,6 +102,7 @@
         'moderator',		'',	# moderator instead of owner-list
         'approve_passwd', 	'#!"$list.pass"',
 				      # password for approving postings
+	'approval_address',     '',   # address to mail approval notices to
         'sender', 		'#!"owner-" . $list',   # Set sender name
         'maxlength', 		'40000',   # Set max article length
         'precedence', 		'bulk',   # Set/install precendence header
@@ -264,6 +265,9 @@
 to allow posting to moderated list, or
 to bypass resend checks.",
 
+'approval_address',
+"Send approval notices to this address instead of <listname>-approval.",
+
 'sender',
 "The envelope and sender address for the
 resent mail. This string has \"\@\" and the value
@@ -409,6 +413,7 @@
         'moderate',		'resend',
         'moderator',		'resend',
         'approve_passwd',	'resend',
+	'approval_address',     'majordomo',
         'sender', 		'majordomo,resend,digest',
         'maxlength', 		'resend,digest',
         'precedence', 		'resend,digest',
@@ -463,6 +468,7 @@
         'moderate',		'grab_bool',
         'moderator',		'grab_word',
         'approve_passwd', 	'grab_word',
+	'approval_address',     'grab_word',
         'sender', 		'grab_word',
         'maxlength', 		'grab_integer',
         'precedence', 		'grab_word',


 - J<



next message in archive
no next message in thread
previous message in archive
Index of Subjects